Skip to content

Deprecates linksys_ap integration (ADR-0004)#25804

Merged
frenck merged 1 commit into
devfrom
frenck-2019-0128
Aug 9, 2019
Merged

Deprecates linksys_ap integration (ADR-0004)#25804
frenck merged 1 commit into
devfrom
frenck-2019-0128

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Aug 9, 2019

Breaking Change:

The Linksys Access Points integration has been deprecated and is pending for removal in Home Assistant 0.100.0.

Description:

This PR deprecates the Linksys Access Points integration since it relies on web scraping to function.
As per ADR-0004 this is no longer allowed. The integration should now be deprecated for 2 releases before permanent removal.

Evidence: https://github.com/home-assistant/home-assistant/blob/4de97ab/homeassistant/components/linksys_ap/device_tracker.py#L82

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10092

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@frenck frenck merged commit e47ed0e into dev Aug 9, 2019
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2019-0128 branch August 9, 2019 14:47
@lock lock Bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants