From b5702c531fa397b5840fbce6e4d2da315cc724f0 Mon Sep 17 00:00:00 2001 From: Gido Date: Mon, 18 Feb 2019 18:49:40 +0100 Subject: [PATCH 1/2] Update rova component with release rova release 0.1.0 Add house_number_suffix to configuration --- homeassistant/components/sensor/rova.py | 7 +++++-- requirements_all.txt | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/sensor/rova.py b/homeassistant/components/sensor/rova.py index 0b7f43f0973e5..4275852e190c9 100644 --- a/homeassistant/components/sensor/rova.py +++ b/homeassistant/components/sensor/rova.py @@ -17,11 +17,12 @@ from homeassistant.helpers.entity import Entity from homeassistant.util import Throttle -REQUIREMENTS = ['rova==0.0.2'] +REQUIREMENTS = ['rova==0.1.0'] # Config for rova requests. CONF_ZIP_CODE = 'zip_code' CONF_HOUSE_NUMBER = 'house_number' +CONF_HOUSE_NUMBER_SUFFIX = 'house_number_suffix' UPDATE_DELAY = timedelta(hours=12) SCAN_INTERVAL = timedelta(hours=12) @@ -37,6 +38,7 @@ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ vol.Required(CONF_ZIP_CODE): cv.string, vol.Required(CONF_HOUSE_NUMBER): cv.string, + vol.Optional(CONF_HOUSE_NUMBER_SUFFIX): cv.string, vol.Optional(CONF_NAME, default='Rova'): cv.string, vol.Optional(CONF_MONITORED_CONDITIONS, default=['bio']): vol.All(cv.ensure_list, [vol.In(SENSOR_TYPES)]) @@ -52,10 +54,11 @@ def setup_platform(hass, config, add_entities, discovery_info=None): zip_code = config[CONF_ZIP_CODE] house_number = config[CONF_HOUSE_NUMBER] + house_number_suffix = config.get(CONF_HOUSE_NUMBER_SUFFIX, '') platform_name = config[CONF_NAME] # Create new Rova object to retrieve data - api = Rova(zip_code, house_number) + api = Rova(zip_code, house_number, house_number_suffix) try: if not api.is_rova_area(): diff --git a/requirements_all.txt b/requirements_all.txt index 22124c3910acf..8c88b3bda983f 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -1502,7 +1502,7 @@ rocketchat-API==0.6.1 roombapy==1.3.1 # homeassistant.components.sensor.rova -rova==0.0.2 +rova==0.1.0 # homeassistant.components.switch.rpi_rf # rpi-rf==0.9.7 From 0b2b5e10c117d0f596f176d9fe341824ccb64722 Mon Sep 17 00:00:00 2001 From: Gido Date: Tue, 19 Feb 2019 07:14:55 +0100 Subject: [PATCH 2/2] Set default value for house_number_suffix --- homeassistant/components/sensor/rova.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/sensor/rova.py b/homeassistant/components/sensor/rova.py index 4275852e190c9..07be331f23f35 100644 --- a/homeassistant/components/sensor/rova.py +++ b/homeassistant/components/sensor/rova.py @@ -38,7 +38,7 @@ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ vol.Required(CONF_ZIP_CODE): cv.string, vol.Required(CONF_HOUSE_NUMBER): cv.string, - vol.Optional(CONF_HOUSE_NUMBER_SUFFIX): cv.string, + vol.Optional(CONF_HOUSE_NUMBER_SUFFIX, default=''): cv.string, vol.Optional(CONF_NAME, default='Rova'): cv.string, vol.Optional(CONF_MONITORED_CONDITIONS, default=['bio']): vol.All(cv.ensure_list, [vol.In(SENSOR_TYPES)]) @@ -54,7 +54,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None): zip_code = config[CONF_ZIP_CODE] house_number = config[CONF_HOUSE_NUMBER] - house_number_suffix = config.get(CONF_HOUSE_NUMBER_SUFFIX, '') + house_number_suffix = config[CONF_HOUSE_NUMBER_SUFFIX] platform_name = config[CONF_NAME] # Create new Rova object to retrieve data