Use CONF_RECIPIENT for default recipient in config#20925
Merged
fabaff merged 2 commits intoFeb 10, 2019
Conversation
dgomes
reviewed
Feb 10, 2019
2 tasks
fabaff
approved these changes
Feb 10, 2019
Member
|
When should we announce the breaking change? Now here, or later when we hit invalidation? |
Member
Author
|
It feels like we need a new section of the release notes for future breaking changes. Because we should announce now that this migration is necessary and will be required when we hit invalidation. |
Contributor
|
if a user can postpone, he will postpone... by all means, a breaking change must be announced ASAP, and not wait for the final version. We are just being nice not actually breaking stuff :) |
Member
Author
|
I think we need it mentioned in every set of release notes between now and invalidation or at the very least once now and once at invalidation. |
Member
Author
|
Tagged as breaking change and breaking change note added. |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Use the new deprecated vol validator to replace
ATTR_TARGETwithCONF_RECIPIENTin tpklink_lte.Breaking Change:
targethas been deprecated and replaced withrecipientin thetplink_lteconfiguration. This is a soft deprecation in this release and will automatically become a hard breaking change in Home Assistant version 0.91.0.Related issue (if applicable): fixes #20671
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8460
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: