Skip to content

Use CONF_RECIPIENT for default recipient in config#20925

Merged
fabaff merged 2 commits into
home-assistant:devfrom
rohankapoorcom:conf_recipient-tplink-default
Feb 10, 2019
Merged

Use CONF_RECIPIENT for default recipient in config#20925
fabaff merged 2 commits into
home-assistant:devfrom
rohankapoorcom:conf_recipient-tplink-default

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Feb 10, 2019

Description:

Use the new deprecated vol validator to replace ATTR_TARGET with CONF_RECIPIENT in tpklink_lte.

Breaking Change: target has been deprecated and replaced with recipient in the tplink_lte configuration. This is a soft deprecation in this release and will automatically become a hard breaking change in Home Assistant version 0.91.0.

Related issue (if applicable): fixes #20671

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8460

Example entry for configuration.yaml (if applicable):

tplink_lte:
  - host: IP_ADDRESS
    password: SECRET
    notify:
      - name: sms1
        recipient: "+15105550123"
      - name: sms2
        recipient: "+55520525252"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Comment thread homeassistant/components/tplink_lte/__init__.py Outdated
@fabaff fabaff merged commit 8f249f9 into home-assistant:dev Feb 10, 2019
@ghost ghost removed the in progress label Feb 10, 2019
@MartinHjelmare
Copy link
Copy Markdown
Member

When should we announce the breaking change? Now here, or later when we hit invalidation?

@rohankapoorcom rohankapoorcom deleted the conf_recipient-tplink-default branch February 10, 2019 22:54
@rohankapoorcom
Copy link
Copy Markdown
Member Author

It feels like we need a new section of the release notes for future breaking changes. Because we should announce now that this migration is necessary and will be required when we hit invalidation.

@dgomes
Copy link
Copy Markdown
Contributor

dgomes commented Feb 10, 2019

if a user can postpone, he will postpone... by all means, a breaking change must be announced ASAP, and not wait for the final version.

We are just being nice not actually breaking stuff :)

@rohankapoorcom
Copy link
Copy Markdown
Member Author

I think we need it mentioned in every set of release notes between now and invalidation or at the very least once now and once at invalidation.

@rohankapoorcom
Copy link
Copy Markdown
Member Author

Tagged as breaking change and breaking change note added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use CONF_RECIPIENT for default recipient in config

5 participants