From 5a930c96b66f17fd4f456370f79b2e6897d934e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20H=C3=B8yer=20Iversen?= Date: Tue, 6 Nov 2018 22:24:39 +0100 Subject: [PATCH 1/2] Fix xiaomi binary_sensor warning --- homeassistant/components/binary_sensor/xiaomi_aqara.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/binary_sensor/xiaomi_aqara.py b/homeassistant/components/binary_sensor/xiaomi_aqara.py index e082c886f036f8..597759f524d3a8 100644 --- a/homeassistant/components/binary_sensor/xiaomi_aqara.py +++ b/homeassistant/components/binary_sensor/xiaomi_aqara.py @@ -357,7 +357,7 @@ def device_state_attributes(self): def parse_data(self, data, raw_data): """Parse data sent by gateway.""" value = data.get(self._data_key) - if value not in ('vibrate', 'tilt', 'free_fall'): + if value not in (None, 'vibrate', 'tilt', 'free_fall'): _LOGGER.warning("Unsupported movement_type detected: %s", value) return False From aa82bac380165bd30d265c803b14d3de7cb8779f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20H=C3=B8yer=20Iversen?= Date: Wed, 7 Nov 2018 13:36:08 +0100 Subject: [PATCH 2/2] Fix xiaomi binary_sensor warning --- homeassistant/components/binary_sensor/xiaomi_aqara.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/homeassistant/components/binary_sensor/xiaomi_aqara.py b/homeassistant/components/binary_sensor/xiaomi_aqara.py index 597759f524d3a8..45217c42c1df37 100644 --- a/homeassistant/components/binary_sensor/xiaomi_aqara.py +++ b/homeassistant/components/binary_sensor/xiaomi_aqara.py @@ -357,7 +357,10 @@ def device_state_attributes(self): def parse_data(self, data, raw_data): """Parse data sent by gateway.""" value = data.get(self._data_key) - if value not in (None, 'vibrate', 'tilt', 'free_fall'): + if value is None: + return False + + if value not in ('vibrate', 'tilt', 'free_fall'): _LOGGER.warning("Unsupported movement_type detected: %s", value) return False