From 32fb6fffd95a313a1ce5b0123c29c7f8c3d8cd7e Mon Sep 17 00:00:00 2001 From: Glen Takahashi Date: Tue, 23 Oct 2018 20:36:20 -0400 Subject: [PATCH] Correct expose_by_default interaction with expose_domains Based on the documentation here: https://www.home-assistant.io/components/google_assistant/#expose_by_default it seems that expose_by_default means all devices should be exposed unless explicitly set to false, and that regardless if this is set domains in exposed_domains should be exposed. --- homeassistant/components/google_assistant/http.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/google_assistant/http.py b/homeassistant/components/google_assistant/http.py index 65af7b932b084f..30d22359580622 100644 --- a/homeassistant/components/google_assistant/http.py +++ b/homeassistant/components/google_assistant/http.py @@ -42,7 +42,7 @@ def is_exposed(entity) -> bool: entity_config.get(entity.entity_id, {}).get(CONF_EXPOSE) domain_exposed_by_default = \ - expose_by_default and entity.domain in exposed_domains + expose_by_default or entity.domain in exposed_domains # Expose an entity if the entity's domain is exposed by default and # the configuration doesn't explicitly exclude it from being