Use asyncio.get_running_loop() in emulated_hue UPnP responder#171000
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Hey there @bdraco, @Tho85, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the emulated_hue UPnP responder to use asyncio.get_running_loop() inside async_create_upnp_datagram_endpoint, avoiding deprecated asyncio.get_event_loop() usage and aligning with modern asyncio expectations.
Changes:
- Replace
asyncio.get_event_loop()withasyncio.get_running_loop()in the UPnP datagram endpoint creation path.
balloob
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The
async_create_upnp_datagram_endpointfunction in the emulated_hue integration usesasyncio.get_event_loop()which has been deprecated since Python 3.10 and will raiseRuntimeErrorin a future Python version.Since this is an
async deffunction, there is always a running event loop. Replaced withasyncio.get_running_loop()which is the idiomatic choice inside coroutines.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: