Watts: add timer mode service#169846
Merged
Merged
Conversation
Contributor
|
Hey there @devender-verma-ww, @ssi-spyro, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new watts.activate_timer_mode service for Watts Vision thermostats, allowing users to switch a thermostat into “timer mode” with a target temperature and duration, and updates the integration to align with the upstream client API change for get_device.
Changes:
- Add
activate_timer_modeplatform entity service wired to a newWattsVisionClimate.async_activate_timer_modemethod. - Add user-facing service metadata (services.yaml, strings.json, icons.json) and integration setup to register the service.
- Update coordinator/tests to reflect the updated
visionpluspythonget_device()signature and add tests for the new service.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/watts/test_switch.py | Updates fast-polling assertion to match updated get_device() call signature. |
| tests/components/watts/test_climate.py | Adds tests for the new timer mode service and updates fast-polling assertion for get_device(). |
| homeassistant/components/watts/strings.json | Adds translated exception messages and service metadata for activate_timer_mode. |
| homeassistant/components/watts/services.yaml | Declares the new service and its UI selectors/fields. |
| homeassistant/components/watts/services.py | Registers the new platform entity service and validates duration input shape/range. |
| homeassistant/components/watts/icons.json | Adds an icon for the new service. |
| homeassistant/components/watts/coordinator.py | Removes the refresh=True argument from get_device() calls. |
| homeassistant/components/watts/const.py | Adds constants for the new service and its duration field. |
| homeassistant/components/watts/climate.py | Implements async_activate_timer_mode with validation, error translation, fast polling, and refresh. |
| homeassistant/components/watts/init.py | Registers services during integration setup and adds config-entry-only schema. |
theobld-ww
force-pushed
the
watts-timer-service
branch
from
60381d4 to
316d360
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
# Conflicts: # homeassistant/components/watts/climate.py # homeassistant/components/watts/icons.json # tests/components/watts/test_climate.py
8 tasks
Comment on lines
+228
to
+233
| _LOGGER.debug( | ||
| "Successfully activated timer mode: %s%s for %d min on %s", | ||
| temperature, | ||
| self.temperature_unit, | ||
| duration_minutes, | ||
| self.device_id, |
Comment on lines
+3
to
8
| from datetime import timedelta | ||
| import logging | ||
| from typing import Any | ||
|
|
||
| from visionpluspython.exceptions import WattsVisionError | ||
| from visionpluspython.models import ThermostatDevice, ThermostatMode |
joostlek
approved these changes
May 11, 2026
Member
|
Please make sure you have the new docs PR ready :) |
8 tasks
Contributor
Author
|
@joostlek doc PR added : home-assistant/home-assistant.io#45311 |
lmaertin
pushed a commit
to lmaertin/homeassistant-core
that referenced
this pull request
May 11, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
May 12, 2026
…-timer * upstream/dev: Bump infrared-protocols to 5.1.0 (home-assistant#170365) Clean up template engine after extension modularization (home-assistant#170346) Bump axis to v71 (home-assistant#170347) Enhance WebDAV metadata download with concurrency (home-assistant#170223) Add target temperature sensor for ViCare RadiatorActuator devices (home-assistant#170102) Bump pyzbar to 0.1.9 (home-assistant#170076) homematicip_cloud: fix HmIP-FLC lock state polarity (home-assistant#170159) Watts: add timer mode service (home-assistant#169846) Set parallel updates for Ecowitt platforms (home-assistant#170349) Add config flow to Avea (home-assistant#168070) Cleanup Eurotronic number platform (home-assistant#170337) Add number platform to eurotronic_cometblue (home-assistant#168119)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: