Add API version to Duco diagnostics for support triage#169802
Merged
jbouwh merged 1 commit intoMay 5, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the Duco diagnostics payload so support downloads include more live device metadata and newer board firmware details, improving troubleshooting for this platinum-quality local integration.
Changes:
- Adds live API metadata to Duco diagnostics and includes newer board firmware/API version fields when available.
- Removes the board
timevalue from diagnostics and keeps sensitive identifiers redacted. - Updates Duco diagnostics fixtures, snapshot data, and connection-error coverage for the new live API call.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/duco/diagnostics.py |
Extends diagnostics collection with API info and filters optional board fields. |
tests/components/duco/conftest.py |
Adds mock API/board data needed for the expanded diagnostics payload. |
tests/components/duco/test_diagnostics.py |
Updates diagnostics tests for the new payload and API-info failure path. |
tests/components/duco/snapshots/test_diagnostics.ambr |
Refreshes the expected diagnostics snapshot with the new fields. |
8e5d8e8 to
20d682f
Compare
Contributor
Author
|
Important Could a maintainer add the |
jbouwh
approved these changes
May 5, 2026
Contributor
jbouwh
left a comment
There was a problem hiding this comment.
LGTM,
Thanks @ronaldvdmeer 👍
gwww
pushed a commit
to gwww/core
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The Duco diagnostics payload currently only reports the device's host address, config entry data, and board info. This PR extends it so that when a user downloads diagnostics for a support request, the output also includes:
public_api_versionand, when present,reported_api_version) fetched live from the device viaasync_get_api_info()public_api_versionandsoftware_version(added in python-duco-client 0.4.0) are included when available, so the exact firmware version is visible without asking the userOptional fields (
reported_api_version,public_api_versionon board,software_versionon board) are only included when the device actually returns them, keeping the payload clean for older hardware.The
timefield is stripped from board info because it is a raw Unix epoch timestamp that adds no value for support triage.Type of change
Additional information
python-duco-client 0.4.0 is a prerequisite; that bump was merged separately in #169776.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: