Fix bang olufsen flaky tests in Python 3.14.3#169345
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
|
Hey there @mj23000, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the Bang & Olufsen integration tests under Python 3.14.3 by ensuring the mocked get_beolink_self() response matches the specific device/config entry used in each test, preventing name/device-info drift during setup and diagnostics collection.
Changes:
- Update Bang & Olufsen tests to explicitly mock
MozartClient.get_beolink_self()for non-default devices (e.g., A5, Premiere). - Extend test imports to include the correct friendly name/JID constants for those devices.
- Refresh diagnostics snapshot expectations to align with the now-deterministic device/entity friendly names.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/bang_olufsen/test_sensor.py | Sets get_beolink_self() mock for A5 battery sensor test to match the A5 config entry identity. |
| tests/components/bang_olufsen/test_event.py | Sets get_beolink_self() mock for Premiere/A5 event-entity creation tests to avoid name mismatches. |
| tests/components/bang_olufsen/test_diagnostics.py | Sets get_beolink_self() mock for A5 diagnostics test and updates imported constants accordingly. |
| tests/components/bang_olufsen/test_binary_sensor.py | Sets get_beolink_self() mock for A5 charging binary sensor test to stabilize naming. |
| tests/components/bang_olufsen/snapshots/test_diagnostics.ambr | Updates snapshot friendly names/device info to reflect the corrected mocked self identity. |
jbouwh
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Spotted in https://github.com/home-assistant/core/actions/runs/25005822536/job/73229778093?pr=162263
Follow-up to #168885 and needed for #162263
The test is flaky because media-player (which updates the friendly name of the device entry) might be initialised before OR after the other platforms.
This ensures that the "updated" friendly name matches the "initial" friendly name.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: