Require admin for addon panel register and delete#169329
Merged
Merged
Conversation
Contributor
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens authorization for the Hass.io add-on panel push API so that only admin users can register or delete add-on panels, aligning these system-wide UI changes with admin-only access expectations.
Changes:
- Require admin privileges for
POST /api/hassio_push/panel/{addon}(panel registration). - Require admin privileges for
DELETE /api/hassio_push/panel/{addon}(panel removal). - Add test coverage verifying non-admin users receive
401 Unauthorizedfor both operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/hassio/addon_panel.py |
Applies @require_admin to panel registration and deletion endpoints. |
tests/components/hassio/test_addon_panel.py |
Adds tests for non-admin access being denied and admin delete still working. |
67b5b02 to
6728ceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Admin role is required to register or delete an addon panel via
/api/hassio_push/panel/{addon}.Proposed change
Admin role is required to register a new panel for an addon or to delete a panel for an addon as these are system-wide behaviors.
When adding a new non-admin user, the UI tells the operator:
This PR is part of that audit.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: