Use defaults for device class UPTIME in Shelly by chemelli74 · Pull Request #169148 · home-assistant/core

chemelli74 · 2026-04-25T14:27:35Z

Breaking change

Sensor for device uptime now uses new sensor class UPTIME:

old entity id: sensor.device_name_last_restart
new entity id: sensor.device_name_uptime

Please review your automations accordly.

Proposed change

Use defaults for device class UPTIME in Shelly

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-04-25T14:27:43Z

Hey there @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Aligns Shelly’s uptime sensors with Home Assistant’s default SensorDeviceClass.UPTIME naming/translation behavior by removing the custom translation key.

Changes:

Drop the translation_key="last_restart" from Shelly REST and RPC uptime sensor descriptions to use the device-class default.
Remove the now-unused last_restart entity name string from strings.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
homeassistant/components/shelly/strings.json	Removes the unused `last_restart` entity name translation entry.
homeassistant/components/shelly/sensor.py	Removes the custom translation key from uptime sensor descriptions so device-class defaults apply.

Copilot · 2026-04-25T14:31:21Z

    "uptime": RestSensorDescription(
        key="uptime",
-        translation_key="last_restart",
        value=lambda status, _: utcnow() - timedelta(seconds=status["uptime"]),
        device_class=SensorDeviceClass.UPTIME,
        entity_registry_enabled_default=False,


Update the PR checklist/description to match the actual changes (either add tests covering the uptime sensor naming change or uncheck the “Tests have been added” item).

thecode · 2026-04-25T14:36:03Z

Can we first fix the frontend to display the correct restart time before proceeding with multiple PRs that we will have to revert if the frontend is not fixed?

epenet · 2026-04-29T07:23:06Z

I don't think this is a breaking change.
The entity will only be renamed on delete/recreate integration (the old name should not get amended on an existing sensor)

epenet · 2026-04-29T07:24:43Z

Can we first fix the frontend to display the correct restart time before proceeding with multiple PRs that we will have to revert if the frontend is not fixed?

Is there an issue/PR tracking frontend changes?

chemelli74 · 2026-04-29T07:58:27Z

I don't think this is a breaking change. The entity will only be renamed on delete/recreate integration (the old name should not get amended on an existing sensor)

I was thinking about migrating it to get it consistent all over, so in each integration you have "uptime" and no longer "last_restart".

Worth adding the migration ?

chemelli74 · 2026-04-29T07:59:11Z

Can we first fix the frontend to display the correct restart time before proceeding with multiple PRs that we will have to revert if the frontend is not fixed?

Is there an issue/PR tracking frontend changes?

home-assistant/frontend#51716

frenck

Thanks, @chemelli74 👍

../Frenck

Blogging my personal ramblings at frenck.dev

bieniu · 2026-04-29T12:09:55Z

I think we should remove breaking-change label.

Use defaults for device class UPTIME in Shelly

992e37e

chemelli74 added this to the 2026.5.0b0 milestone Apr 25, 2026

Copilot AI review requested due to automatic review settings April 25, 2026 14:27

chemelli74 requested review from bdraco, bieniu and thecode as code owners April 25, 2026 14:27

home-assistant Bot added cla-signed code-quality integration: shelly small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage labels Apr 25, 2026

home-assistant Bot assigned bieniu, thecode and bdraco Apr 25, 2026

home-assistant Bot added by-code-owner Quality Scale: platinum labels Apr 25, 2026

Copilot started reviewing on behalf of chemelli74 April 25, 2026 14:28 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

update snapshots

96d6656

chemelli74 added the breaking-change label Apr 25, 2026

frenck approved these changes Apr 29, 2026

View reviewed changes

frenck merged commit d41a3ae into home-assistant:dev Apr 29, 2026
33 checks passed

chemelli74 deleted the chemelli74-shelly-strings branch April 29, 2026 08:16

chemelli74 removed the breaking-change label Apr 29, 2026

github-actions Bot locked and limited conversation to collaborators Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use defaults for device class UPTIME in Shelly#169148

Use defaults for device class UPTIME in Shelly#169148
frenck merged 2 commits into
home-assistant:devfrom
chemelli74:chemelli74-shelly-strings

chemelli74 commented Apr 25, 2026 •

edited

Loading

Uh oh!

home-assistant Bot commented Apr 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

thecode commented Apr 25, 2026

Uh oh!

epenet commented Apr 29, 2026

Uh oh!

epenet commented Apr 29, 2026 •

edited

Loading

Uh oh!

chemelli74 commented Apr 29, 2026

Uh oh!

chemelli74 commented Apr 29, 2026

Uh oh!

frenck left a comment

Uh oh!

Uh oh!

bieniu commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

chemelli74 commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Apr 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

thecode commented Apr 25, 2026

Uh oh!

epenet commented Apr 29, 2026

Uh oh!

epenet commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chemelli74 commented Apr 29, 2026

Uh oh!

chemelli74 commented Apr 29, 2026

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bieniu commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chemelli74 commented Apr 25, 2026 •

edited

Loading

epenet commented Apr 29, 2026 •

edited

Loading