Skip to content

Fix jvcprojector entities going unavailable on transient command errors#168985

Merged
frenck merged 2 commits into
home-assistant:devfrom
SteveEasley:pyjvcprojector2.0.6
Apr 29, 2026
Merged

Fix jvcprojector entities going unavailable on transient command errors#168985
frenck merged 2 commits into
home-assistant:devfrom
SteveEasley:pyjvcprojector2.0.6

Conversation

@SteveEasley
Copy link
Copy Markdown
Contributor

Proposed change

Bump pyjvcprojector dependency to v2.0.6 to fix #165782. Diff SteveEasley/pyjvcprojector@v2.0.5...v2.0.6.

This PR bumps the dep, and wraps the problem code with the newly created exception.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings April 23, 2026 20:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the jvc_projector integration to use pyjvcprojector==2.0.6 and adapts the coordinator to tolerate transient per-command failures so entities don’t all become unavailable due to a single command error.

Changes:

  • Bump pyjvcprojector from 2.0.5 to 2.0.6 across manifest and requirements lock files.
  • Catch JvcProjectorCommandError during per-command polling and fall back to cached state instead of failing the whole update.
  • Add a coordinator test to verify a command error doesn’t take unrelated entities offline.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
homeassistant/components/jvc_projector/coordinator.py Handles JvcProjectorCommandError during polling to keep coordinator updates succeeding.
homeassistant/components/jvc_projector/manifest.json Pins pyjvcprojector to 2.0.6 for the integration runtime dependency.
requirements_all.txt Updates global dependency pin for pyjvcprojector to 2.0.6.
requirements_test_all.txt Updates test dependency pin for pyjvcprojector to 2.0.6.
tests/components/jvc_projector/test_coordinator.py Adds coverage for command-error behavior so entities remain available.

Comment thread homeassistant/components/jvc_projector/coordinator.py Outdated
Comment thread homeassistant/components/jvc_projector/coordinator.py Outdated
Comment thread homeassistant/components/jvc_projector/coordinator.py
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SteveEasley 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 3dd972c into home-assistant:dev Apr 29, 2026
48 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JVC Projector Integration fails with Read Timeout

3 participants