Fix jvcprojector entities going unavailable on transient command errors#168985
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the jvc_projector integration to use pyjvcprojector==2.0.6 and adapts the coordinator to tolerate transient per-command failures so entities don’t all become unavailable due to a single command error.
Changes:
- Bump
pyjvcprojectorfrom 2.0.5 to 2.0.6 across manifest and requirements lock files. - Catch
JvcProjectorCommandErrorduring per-command polling and fall back to cached state instead of failing the whole update. - Add a coordinator test to verify a command error doesn’t take unrelated entities offline.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/jvc_projector/coordinator.py |
Handles JvcProjectorCommandError during polling to keep coordinator updates succeeding. |
homeassistant/components/jvc_projector/manifest.json |
Pins pyjvcprojector to 2.0.6 for the integration runtime dependency. |
requirements_all.txt |
Updates global dependency pin for pyjvcprojector to 2.0.6. |
requirements_test_all.txt |
Updates test dependency pin for pyjvcprojector to 2.0.6. |
tests/components/jvc_projector/test_coordinator.py |
Adds coverage for command-error behavior so entities remain available. |
frenck
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Bump pyjvcprojector dependency to v2.0.6 to fix #165782. Diff SteveEasley/pyjvcprojector@v2.0.5...v2.0.6.
This PR bumps the dep, and wraps the problem code with the newly created exception.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: