Skip to content

Start reauth when roborock notices the MQTT session is unauthorized#159719

Merged
zweckj merged 1 commit into
home-assistant:devfrom
allenporter:roborock-unauthorized
Dec 25, 2025
Merged

Start reauth when roborock notices the MQTT session is unauthorized#159719
zweckj merged 1 commit into
home-assistant:devfrom
allenporter:roborock-unauthorized

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

@allenporter allenporter commented Dec 24, 2025

Proposed change

Start reauth when roborock notices the MQTT session is unauthorized

The integration registers a callback with the Roborock Device Manager which is invoked when the
background thread notices the MQTT session is no longer valid. This is needed since we no longer block on an MQTT connection on startup since we prefer local device connection, but still need a way to notice the session has gone bad.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This is invoked when the background thread notices the MQTT session is no longer valid.
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a callback mechanism to handle MQTT session unauthorized events in the Roborock integration. When the device manager's background thread detects that the MQTT session is no longer valid, it triggers a reauth flow to prompt users to update their credentials.

Key changes:

  • Adds mqtt_session_unauthorized_hook callback parameter to device manager initialization
  • Implements reauth flow trigger when MQTT authorization fails in background operations
  • Adds test coverage for the new unauthorized hook callback functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/roborock/__init__.py Adds lambda callback to create_device_manager that triggers reauth flow when MQTT session becomes unauthorized
tests/components/roborock/test_init.py Adds test to verify the MQTT unauthorized hook correctly initiates the reauth flow

Comment thread homeassistant/components/roborock/__init__.py
"mqtt_session_unauthorized_hook"
)
assert mqtt_session_unauthorized_hook
mqtt_session_unauthorized_hook()
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After calling the mqtt_session_unauthorized_hook, you need to call await hass.async_block_till_done() to allow the async task created by async_start_reauth to complete. The async_start_reauth method creates a task via hass.async_create_task, and without waiting for pending tasks to complete, the reauth flow may not be fully initialized when you check for it.

Add await hass.async_block_till_done() after line 125 and before checking for flows.

Suggested change
mqtt_session_unauthorized_hook()
mqtt_session_unauthorized_hook()
await hass.async_block_till_done()

Copilot uses AI. Check for mistakes.
@zweckj zweckj merged commit 5657bd1 into home-assistant:dev Dec 25, 2025
41 of 42 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock showing current room as unknown and map not updating - MQTT session fails w [code:135] Not authorized

4 participants