Bump insteon panel to 0.6.0 to fix dialog button issues#159449
Merged
Conversation
home-assistant
Bot
added
bugfix
cla-signed
dependency
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @ziv1234, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Insteon integration's frontend and backend dependencies to fix dialog button issues. The main updates include bumping insteon-frontend-home-assistant from 0.5.0 to 0.6.0 and pyinsteon from 1.6.3 to 1.6.4, along with necessary code changes to support the new frontend package structure.
Key changes:
- Dependency version bumps for both the Insteon frontend panel and pyinsteon library
- URL format correction from dash to dot separator (
entrypoint-{build_id}.js→entrypoint.{build_id}.js) to match the new frontend package structure - Bug fix in properties reset functionality to include
device.configurationitems
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements_test_all.txt | Updated test dependencies for insteon-frontend-home-assistant (0.5.0 → 0.6.0) and pyinsteon (1.6.3 → 1.6.4) |
| requirements_all.txt | Updated production dependencies for insteon-frontend-home-assistant (0.5.0 → 0.6.0) and pyinsteon (1.6.3 → 1.6.4) |
| homeassistant/components/insteon/manifest.json | Updated integration requirements to reference new dependency versions |
| homeassistant/components/insteon/api/properties.py | Added missing reset loop for device.configuration values in websocket_reset_properties |
| homeassistant/components/insteon/api/init.py | Updated module URL format from dash to dot separator for new frontend package structure |
| homeassistant/components/dynalite/panel.py | Updated module URL format from dash to dot separator for consistency with updated pattern |
Comments suppressed due to low confidence (1)
homeassistant/components/insteon/api/properties.py:290
- The iteration pattern is inconsistent across these three loops. Line 285 iterates over
.values()and accesses the property directly, while lines 287 and 289 iterate over keys and then access the dictionary using those keys. For consistency and readability, all three loops should use the same pattern. Consider either changing line 285 tofor prop in device.configuration:followed bydevice.configuration[prop].new_value = None, or changing lines 287-290 to iterate over.values()like line 285 does.
for prop in device.configuration.values():
prop.new_value = None
for prop in device.operating_flags:
device.operating_flags[prop].new_value = None
for prop in device.properties:
device.properties[prop].new_value = None
joostlek
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Upgrade the Insteon configuration panel to the new version.
Change log: pyinsteon/insteon-panel@0.5.0...2025.12.19.154216
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: