Skip to content

Improve service schemas in unifiprotect#150236

Merged
joostlek merged 1 commit into
home-assistant:devfrom
arturpragacz:unifiprotect/improve-service-schemas
Aug 8, 2025
Merged

Improve service schemas in unifiprotect#150236
joostlek merged 1 commit into
home-assistant:devfrom
arturpragacz:unifiprotect/improve-service-schemas

Conversation

@arturpragacz
Copy link
Copy Markdown
Member

@arturpragacz arturpragacz commented Aug 7, 2025

Proposed change

Improve service schemas in unifiprotect.

As those services required just devices, using ENTITY_SERVICE_FIELDS was unnecessarily complex.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings August 7, 2025 22:43
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Aug 7, 2025

Hey there @RaHehl, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves service schemas in the UniFi Protect integration by simplifying schema definitions and making device_id fields required. The changes remove unnecessary complexity from schema validation while maintaining the same functional requirements.

Key changes:

  • Simplified schema definitions by removing nested vol.All wrappers
  • Made device_id explicitly required instead of using has_at_least_one_key validation
  • Updated field definitions for better clarity and consistency

Comment thread homeassistant/components/unifiprotect/services.py
@joostlek joostlek merged commit 2d89c60 into home-assistant:dev Aug 8, 2025
34 checks passed
@arturpragacz arturpragacz deleted the unifiprotect/improve-service-schemas branch August 8, 2025 23:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants