Skip to content

Remove old compatibility code (and add new warning) in lifx#132730

Merged
frenck merged 1 commit into
devfrom
epenet-20241209-1637
Dec 9, 2024
Merged

Remove old compatibility code (and add new warning) in lifx#132730
frenck merged 1 commit into
devfrom
epenet-20241209-1637

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Dec 9, 2024

Breaking change

color_temp and kelvin are no longer valid arguments for lifx service calls.
Please use color_temp_kelvin instead.

Proposed change

See #81515 and #82067

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added breaking-change cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: lifx small-pr PRs with less than 30 lines. labels Dec 9, 2024
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 9, 2024

Hey there @Djelibeybi, mind taking a look at this pull request as it has been labeled with an integration (lifx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lifx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lifx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

../Frenck

@frenck frenck merged commit 07d8778 into dev Dec 9, 2024
@frenck frenck deleted the epenet-20241209-1637 branch December 9, 2024 21:49
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking-change cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: lifx Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants