Move several local services to their right domain#11677
Merged
Conversation
houndci-bot
reviewed
Jan 15, 2018
| from homeassistant.util import Throttle | ||
| from homeassistant.components.switch import (SwitchDevice, PLATFORM_SCHEMA) | ||
| from homeassistant.components.switch import (SwitchDevice, DOMAIN, | ||
| PLATFORM_SCHEMA) |
There was a problem hiding this comment.
continuation line under-indented for visual indent
balloob
approved these changes
Jan 15, 2018
2 tasks
balloob
pushed a commit
that referenced
this pull request
Jan 16, 2018
* Move several local services to their right domain * Fix lint
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since #11479 we try to load
services.yamlbased on the domain of registered services. This has now revealed several platforms that register services outside their own domain, causing an exception during theservices.yamlloading.This PR renames the services to follow the usual convention of keeping the domain and prepending the platform to the service name:
The affected platforms were located with this command:
I do not use any of these platforms so this is currently completely untested.
Related issue (if applicable): fixes #11654
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4424
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.New dependencies have been added to theREQUIREMENTSvariable (example).New dependencies are only imported inside functions that use them (example).New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.