Skip to content

Upgrade coinmarketcap to 4.1.2#11634

Merged
pvizeli merged 1 commit into
devfrom
upgrade-coinmarketcap
Jan 14, 2018
Merged

Upgrade coinmarketcap to 4.1.2#11634
pvizeli merged 1 commit into
devfrom
upgrade-coinmarketcap

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Jan 14, 2018

Description:

  • Add a '/' after the currency id for api requests

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: coinmarketcap
    currency: bitcoin

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@pvizeli pvizeli merged commit 688d706 into dev Jan 14, 2018
@pvizeli pvizeli deleted the upgrade-coinmarketcap branch January 14, 2018 21:31
@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants