Skip to content

upgrade xiaomi lib#11629

Merged
Danielhiversen merged 1 commit into
devfrom
xiaomi_lib
Jan 13, 2018
Merged

upgrade xiaomi lib#11629
Danielhiversen merged 1 commit into
devfrom
xiaomi_lib

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@Danielhiversen Danielhiversen merged commit c33b171 into dev Jan 13, 2018
@Danielhiversen Danielhiversen deleted the xiaomi_lib branch January 13, 2018 20:35
@arsaboo
Copy link
Copy Markdown
Contributor

arsaboo commented Jan 13, 2018

This could also be added to 0.61 milestone.

@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants