added smappee component by hmn · Pull Request #11491 · home-assistant/core

hmn · 2018-01-06T17:08:59Z

Description:

Added components for https://www.smappee.com/

Example entry for `configuration.yaml` (if applicable):

smappee:
    host: 10.0.0.5
    client_id: YOUR_CLIENT_ID
    client_secret: YOUR_CLIENT_SECRET
    username: YOUR_MYSMAPPEE_USERNAME
    password: YOUR_MYSMAPPEE_PASSWORD

Checklist:

The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
New dependencies are only imported inside functions that use them ([example][ex-import]).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

… credentials Added coverage omit

Fixed pylint errors and a few use cases when starting up with invalid…

Added a few more sensors Added more error handling Better parsing and debug message

Added support to run only locally

* dev: upgrade schiene to 0.20 (#11504) Upgrade pywebpush to 1.5.0 (#11497) Fix time functions would throw errors in python scripts (#11414) Clean up Alexa.intent and DialogFlow.intent (#11492) Add missing configuration variables (#11390) Add new iGlo component (#11171) Upgrade pysnmp to 4.4.4 (#11485)

* dev: Address missed review comments for Dark Sky weather (#11520) Fix canary flaky test (#11519) Lazy loading of service descriptions (#11479) Add Dark Sky weather component (#11435) Snips (new) added speech response, parse snips/duration (#11513) More tolerant KNX component if gateway cant be connected (#11511) timer: include the remaining time in the state attributes (#11510)

* dev: Reconnect before mochad switch send command (#11296) New features for Owntracks device_tracker (#11480)

* Merged with local version * Updated smappy library with the patched one Fixed lint, added merge missing param Fixed missing run for requirements_all.txt Fixed lint * Fixed on/off based on library. Reverted change used for testing stacktrace * Fixed switches to work with both remote and local active Fixed lint Fixed switches Fixed lint

…ystem

gieljnssns · 2018-01-12T08:15:39Z

@@ -0,0 +1,290 @@
+"""
+Support for Digital Ocean.


Shouldn't this be Smappee

* dev: (85 commits) Bump dev to 0.62.0.dev0 (#11652) Add Deconz support for Zigbee green power devices like Hue Tap (#11455) Update Pyarlo to 0.1.2 (#11626) Use kelvin/mireds correctly for setting iglo white (#11622) patch stop command (#11612) Upgrade yarl to 0.18.0 (#11609) Xiaomi lib upgrade (#11603) Bugfix and cleanup for Rfxtrx (#11600) Concord232 alarm arm away fix (#11597) Snips add say and say_actions services (new) (#11596) Fix state for trigger with forced updates (#11595) Pushbullet email support (fix) (#11590) Fix Tahoma stop command for 2 types of shutters (#11588) Core support for hass.io calls & Bugfix check_config (#11571) Avoid returning empty media_image_url string (#11557) Upgrade coinmarketcap to 4.1.2 (#11634) Update CODEOWNERS Add templates to MQTT climate (#11623) upgrade xiaomi lib (#11629) Fixes and enhancements for the Tahoma platform (#11547) ...

dcsg · 2018-02-02T21:46:01Z

+1

balloob · 2018-02-18T07:09:29Z

+    def update(self):
+        """Get the latest data from Smappee and update the state."""
+        if self._sensor == 'alwaysOn':
+            data = self._smappee.get_consumption(


This is doing a call to the API per sensor per update (every 30 seconds!). Any way you can fetch all data at once?

balloob · 2018-02-18T07:10:06Z

+                self._state = round(power, 2)
+                self._timestamp = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
+        else:
+            return None


Remove this. Does nothing.

balloob · 2018-02-18T07:12:08Z

+        """Get switches from local Smappee."""
+        if self.is_local_active:
+            return self._localsmappy.load_command_control_config()
+        return False


Inconsistent return type

balloob · 2018-02-18T07:12:24Z

+                _LOGGER.error(
+                    "Error getting comsumption from Smappee cloud. (%s)",
+                    error)
+                return False


Inconsistent return type

balloob · 2018-02-18T07:12:52Z

+                self._timestamp = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
+                self._state = round(consumption.get('solar') / 1000, 2)
+        elif self._sensor == 'power_today':
+            data = self._smappee.get_consumption(


There is no error handling being done here. This method can return False.

balloob · 2018-02-18T07:13:24Z

+        # 3 = daily values,
+        # 4 = monthly values,
+        # 5 = quarterly values
+        if self.is_remote_active:


Use guard clause

if not self.is_remote_active: return end = …

balloob · 2018-02-18T07:14:30Z

+        # 3 = daily values,
+        # 4 = monthly values,
+        # 5 = quarterly values
+        if self.is_remote_active:


guard clause

balloob · 2018-02-18T07:14:50Z

+                    error)
+                return False
+
+        return False


These error values are never handled. Probably better to propagate the error to the update method of the sensor.

balloob · 2018-02-18T07:15:03Z

+            self._smappy.actuator_on(location_id, actuator_id, duration)
+        else:
+            self._localsmappy.on_command_control(actuator_id)
+            return True


Inconsistent return

balloob · 2018-02-18T07:15:17Z

+
+    def instantaneous_values(self):
+        """ReportInstantaneousValues."""
+        if self.is_local_active:


guard clause

balloob · 2018-02-18T07:16:27Z

+    # Skip local switches if remote available
+    if not smappee.is_remote_active:
+        local_devices = smappee.local_devices
+        if smappee.is_local_active:


Merge with parent if statement.

balloob · 2018-02-18T07:16:44Z

+
+    def turn_on(self, **kwargs):
+        """Turn on Comport Plug."""
+        self._smappee.actuator_on(self._location_id, self._switch_id,


Why do this twice?

balloob · 2018-02-18T07:17:26Z

+                                  self._remoteswitch)
+        self._smappee.actuator_on(self._location_id, self._switch_id,
+                                  self._remoteswitch)
+        self._state = True


Why are you setting state to True? You can only do that if you check the command result and make sure the command was successful.

Also, Home Assistant calls your update method after calling a service, which will also query your device

The plugs don't have any way of communicating with the rest of the smappee system, they work by just sending a signal out and then hoping it is received.

It's not really very nice so setting the state seemed to be the only way I could handle them, if theres a better way to handle switches where you can't get the status just point me in that direction and I'll look into it

balloob · 2018-02-18T07:18:00Z

Please include a link to the docs PR.

hmn · 2018-02-18T13:10:50Z

Docs PR is here home-assistant/home-assistant.io#4354

- update smappy module - cache cloud api requests - added actuator info - updated return states

hmn · 2018-02-18T13:55:59Z

Thanks for al of the feedback, I tried fixing all of it, but I'm not exactly a python expert, so I hope it's better :)

balloob · 2018-02-18T22:34:35Z

Awesome work! 🎉

added smappee component

e2f5fd2

hmn requested a review from andrey-git as a code owner January 6, 2018 17:08

homeassistant added cla-signed new-platform platform: sensor.smappee integration: smappee labels Jan 6, 2018

hmn mentioned this pull request Jan 6, 2018

added smappee documentation home-assistant/home-assistant.io#4354

Merged

2 tasks

ciotlosm and others added 2 commits January 6, 2018 21:46

Fixed pylint errors and a few use cases when starting up with invalid…

96de31b

… credentials Added coverage omit

Merge pull request #1 from ciotlosm/smappee

313f18d

Fixed pylint errors and a few use cases when starting up with invalid…

homeassistant added the cla-signed label Jan 6, 2018

balloobbot added component platform requirement labels Jan 6, 2018

ciotlosm and others added 2 commits January 7, 2018 17:47

Added support to run only locally

286523b

Added a few more sensors Added more error handling Better parsing and debug message

Merge pull request #2 from ciotlosm/smappee

a854a08

Added support to run only locally

homeassistant added the cla-signed label Jan 7, 2018

Henrik Nicolaisen and others added 8 commits January 7, 2018 18:19

fixed smappee switch after local/remote support was added

7784cf3

Merge branch 'dev' into smappee

67ae8f0

* dev: Reconnect before mochad switch send command (#11296) New features for Owntracks device_tracker (#11480)

nothing to update per switch as the states are not saved by smappee s…

1c3edbe

…ystem

added better error handling for communication errors with smappee

dd47a67

fixed lint errors

691583a

gieljnssns reviewed Jan 12, 2018

View reviewed changes

Henrik Nicolaisen added 3 commits January 15, 2018 08:21

fixed comment

2536f17

fixed lint error

ada9f24

balloob reviewed Feb 18, 2018

View reviewed changes

balloob added the docs-missing label Feb 18, 2018

update smappee module with reviewer comments

0097f02

- update smappy module - cache cloud api requests - added actuator info - updated return states

homeassistant added the cla-signed label Feb 18, 2018

balloob removed the docs-missing label Feb 18, 2018

balloob approved these changes Feb 18, 2018

View reviewed changes

balloob merged commit 72fa170 into home-assistant:dev Feb 18, 2018

balloob mentioned this pull request Feb 22, 2018

0.64.0 #12609

Merged

hmn deleted the smappee branch February 26, 2018 07:43

home-assistant locked and limited conversation to collaborators May 29, 2018

ghost removed platform: sensor.smappee labels Mar 21, 2019

Uh oh!

Conversation

hmn commented Jan 6, 2018

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcsg commented Feb 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Feb 18, 2018

Uh oh!

hmn commented Feb 18, 2018

Uh oh!

hmn commented Feb 18, 2018

Uh oh!

balloob commented Feb 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Example entry for `configuration.yaml` (if applicable):