Add Dark Sky weather component#11435
Merged
Merged
Conversation
DanNixon
force-pushed
the
darksky_weather
branch
from
43cc481 to
8799508
Compare
2 tasks
DanNixon
force-pushed
the
darksky_weather
branch
from
8799508 to
ebe70e3
Compare
DanNixon
force-pushed
the
darksky_weather
branch
from
ebe70e3 to
f8a8eba
Compare
balloob
approved these changes
Jan 7, 2018
Member
|
Awesome, thanks! 🌮 🐬 |
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks great! Two comments.
| return self._ds_daily.summary | ||
|
|
||
| @property | ||
| def state_attributes(self): |
Member
There was a problem hiding this comment.
You should not overwrite this but implement device_state_attributes. Those will update the state attributes in the entity base class.
| Patform for retrieving meteorological data from Dark Sky. | ||
|
|
||
| For more details about this platform, please refer to the documentation | ||
| https://home-assistant.io/components/ |
6 tasks
Contributor
Author
|
@MartinHjelmare I've opened #11520 to address your comments. |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds weather component that pulls data from Dark Sky.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4333
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passNew dependencies have been added to theREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.