Fix time functions would throw errors in python scripts#11414
Merged
Conversation
Contributor
|
Hi @tomwaters, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
balloob
approved these changes
Jan 3, 2018
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Awesome.
Ok to merge when test added.
houndci-bot
reviewed
Jan 6, 2018
| attribute = getattr(time, attr) | ||
| if callable(attribute): | ||
| def wrapper(*args, **kw): | ||
| """Wrapper to return callable method if attribute is callable.""" |
houndci-bot
reviewed
Jan 6, 2018
| attribute = getattr(time, attr) | ||
| if callable(attribute): | ||
| def wrapper(*args, **kw): | ||
| """Wrapper to return callable method if attribute is callable.""" |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Python scripts would fail when using time functions. For example a python script containing:
t = time.strptime('08:00', '%H:%M')
Will throw:
Error executing script: 'import'
Related issue (if applicable): fixes #N/A
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#N/A
Example entry for
configuration.yaml(if applicable): N/AChecklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass