Bump roombapy to 1.6.13#111187
Merged
Merged
Conversation
Contributor
|
Hey there @pschmitt, @cyr-ius, @shenxn, @Xitee1, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Member
|
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant. Thanks already! 👍 |
Contributor
Author
|
Done. |
joostlek
approved these changes
Feb 23, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
release-notes: https://github.com/pschmitt/roombapy/releases/tag/1.6.13
diff: pschmitt/roombapy@1.6.12...1.6.13
This fixes dependency conflict for paho-mqtt, introduced in pschmitt/roombapy#224 and fixed in pschmitt/roombapy#257.
It was caused by too loose version constraint for dependency. It was fixed too.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: