Skip to content

Simplify ESPHome entity removal process#111076

Merged
bdraco merged 1 commit into
devfrom
esphome_simplify_remove_entities
Feb 22, 2024
Merged

Simplify ESPHome entity removal process#111076
bdraco merged 1 commit into
devfrom
esphome_simplify_remove_entities

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 21, 2024

Proposed change

Now that #110978 is fixed, we can remove most of entity removal code in ESPHome as deleting it from the registry will take care of removing the entity

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Now that #110978 is fixed, we can remove most of entity removal
code in ESPHome as deleting it from the registry will take
care of removing the entity
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Feb 22, 2024

functional retest is good.

Couldn't test it properly while traveling 😉

@bdraco bdraco marked this pull request as ready for review February 22, 2024 21:39
@bdraco bdraco merged commit fb7da1b into dev Feb 22, 2024
@bdraco bdraco deleted the esphome_simplify_remove_entities branch February 22, 2024 21:39
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants