From 4093943f8c2f5745955775ccc7e033c915e0fe4c Mon Sep 17 00:00:00 2001 From: mib1185 Date: Fri, 16 Feb 2024 22:56:33 +0000 Subject: [PATCH 1/3] bump roombapy to 1.6.11 --- homeassistant/components/roomba/manifest.json | 2 +- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/roomba/manifest.json b/homeassistant/components/roomba/manifest.json index fbe6c9254380a1..118631c4c8eb9a 100644 --- a/homeassistant/components/roomba/manifest.json +++ b/homeassistant/components/roomba/manifest.json @@ -24,7 +24,7 @@ "documentation": "https://www.home-assistant.io/integrations/roomba", "iot_class": "local_push", "loggers": ["paho_mqtt", "roombapy"], - "requirements": ["roombapy==1.6.10"], + "requirements": ["roombapy==1.6.11"], "zeroconf": [ { "type": "_amzn-alexa._tcp.local.", diff --git a/requirements_all.txt b/requirements_all.txt index 0a6d3507767a38..1ecd00b08be7f9 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -2459,7 +2459,7 @@ rokuecp==0.19.0 romy==0.0.7 # homeassistant.components.roomba -roombapy==1.6.10 +roombapy==1.6.11 # homeassistant.components.roon roonapi==0.1.6 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index 2c1edf54c53f0d..fa0bdc98eca953 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -1884,7 +1884,7 @@ rokuecp==0.19.0 romy==0.0.7 # homeassistant.components.roomba -roombapy==1.6.10 +roombapy==1.6.11 # homeassistant.components.roon roonapi==0.1.6 From 5d1ac525a09c927a6aeb574774094e2bf71b562d Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Tue, 20 Feb 2024 18:38:58 +0100 Subject: [PATCH 2/3] Apply suggestions from code review --- homeassistant/components/roomba/manifest.json | 2 +- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/roomba/manifest.json b/homeassistant/components/roomba/manifest.json index 118631c4c8eb9a..3d524dcf1d8956 100644 --- a/homeassistant/components/roomba/manifest.json +++ b/homeassistant/components/roomba/manifest.json @@ -24,7 +24,7 @@ "documentation": "https://www.home-assistant.io/integrations/roomba", "iot_class": "local_push", "loggers": ["paho_mqtt", "roombapy"], - "requirements": ["roombapy==1.6.11"], + "requirements": ["roombapy==1.6.12"], "zeroconf": [ { "type": "_amzn-alexa._tcp.local.", diff --git a/requirements_all.txt b/requirements_all.txt index 1ecd00b08be7f9..eca56892706a15 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -2459,7 +2459,7 @@ rokuecp==0.19.0 romy==0.0.7 # homeassistant.components.roomba -roombapy==1.6.11 +roombapy==1.6.12 # homeassistant.components.roon roonapi==0.1.6 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index fa0bdc98eca953..51d7c63f3049e3 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -1884,7 +1884,7 @@ rokuecp==0.19.0 romy==0.0.7 # homeassistant.components.roomba -roombapy==1.6.11 +roombapy==1.6.12 # homeassistant.components.roon roonapi==0.1.6 From 646df69b8474123c22b1c418193dda27b19d80a4 Mon Sep 17 00:00:00 2001 From: mib1185 Date: Wed, 21 Feb 2024 16:42:56 +0000 Subject: [PATCH 3/3] "fix" tests (make them pydantic fiendly?) --- tests/components/roomba/test_config_flow.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/components/roomba/test_config_flow.py b/tests/components/roomba/test_config_flow.py index 5cdd3759d63d5e..4d44035893dbe0 100644 --- a/tests/components/roomba/test_config_flow.py +++ b/tests/components/roomba/test_config_flow.py @@ -98,12 +98,12 @@ def _mocked_discovery(*_): roomba = RoombaInfo( hostname="irobot-BLID", - robot_name="robot_name", + robotname="robot_name", ip=MOCK_IP, mac="mac", - firmware="firmware", + sw="firmware", sku="sku", - capabilities="capabilities", + cap={"cap": 1}, ) roomba_discovery.get_all = MagicMock(return_value=[roomba])