-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename photovoltaic entities to "PV" to differentiate from thermal Solar #128859
Comments
Hey there @CFenner, mind taking a look at this issue as it has been labeled with an integration ( Code owner commandsCode owners of
(message by CodeOwnersMention) vicare documentation |
And probably something that can be done alongside the fix above: The custom attributes of the main climate entity are not available in the strings file for the integration to translate. Thus they show up in English: The standard climate attributes higher up in the list (not visible in the screenshot) are all showing up in German here as expected. FYI: In actions there is a frontend bug that HVAC modes and presets don't show up localized: |
Hi @CFenner , I saw you added 'Cooling electricity' entities today. Do you have time to address the photovoltaic and pump entities in the coming days? And let me know what you think about the custom climate attributes not showing up on Automations. "Heating curve shift" and "Heating curve slope" show up translated in the device UI, but those are separate entities, not attributes of the main Heating entity: So I assume that the integration also needs to provide a list of keys for these attributes so we can translate them? |
The problem
In the Vicare integration there are seven entities which relate to PV installations, obvious from their entity IDs:
core/homeassistant/components/vicare/strings.json
Lines 349 to 372 in 1f9c06e
These should have their entity names changed from "Solar …" to "PV …" to differentiate them from this group:
core/homeassistant/components/vicare/strings.json
Lines 293 to 303 in 1f9c06e
Here the use of "power" in the entity IDs is wrong and should be replaced with "energy".
Alongside the name of this entity
core/homeassistant/components/vicare/strings.json
Lines 33 to 35 in c294130
should be changed to "Heating circulation pump" to make it consistent with this one:
core/homeassistant/components/vicare/strings.json
Lines 51 to 53 in c294130
Avoids major misunderstandings as in Germany the circulation pump is only known for DHW.
What version of Home Assistant Core has the issue?
2024.10.3
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Viessmann ViCare
Link to integration documentation on our website
https://www.home-assistant.io/integrations/vicare/
The text was updated successfully, but these errors were encountered: