Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename photovoltaic entities to "PV" to differentiate from thermal Solar #128859

Open
NoRi2909 opened this issue Oct 20, 2024 · 3 comments
Open

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 20, 2024

The problem

In the Vicare integration there are seven entities which relate to PV installations, obvious from their entity IDs:

"photovoltaic_power_production_current": {
"name": "Solar power"
},
"photovoltaic_energy_production_today": {
"name": "Solar energy production today"
},
"photovoltaic_energy_production_this_week": {
"name": "Solar energy production this week"
},
"photovoltaic_energy_production_this_month": {
"name": "Solar energy production this month"
},
"photovoltaic_energy_production_this_year": {
"name": "Solar energy production this year"
},
"photovoltaic_energy_production_total": {
"name": "Solar energy production total"
},
"photovoltaic_status": {
"name": "Solar state",
"state": {
"ready": "Standby",
"production": "Producing"
}

These should have their entity names changed from "Solar …" to "PV …" to differentiate them from this group:

"solar_power_production_today": {
"name": "Solar energy production today"
},
"solar_power_production_this_week": {
"name": "Solar energy production this week"
},
"solar_power_production_this_month": {
"name": "Solar energy production this month"
},
"solar_power_production_this_year": {
"name": "Solar energy production this year"

Here the use of "power" in the entity IDs is wrong and should be replaced with "energy".

Alongside the name of this entity

"circulation_pump": {
"name": "Circulation pump"
},

should be changed to "Heating circulation pump" to make it consistent with this one:

"domestic_hot_water_circulation_pump": {
"name": "DHW circulation pump"
},

Avoids major misunderstandings as in Germany the circulation pump is only known for DHW.

What version of Home Assistant Core has the issue?

2024.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Viessmann ViCare

Link to integration documentation on our website

https://www.home-assistant.io/integrations/vicare/

@home-assistant
Copy link

Hey there @CFenner, mind taking a look at this issue as it has been labeled with an integration (vicare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vicare can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign vicare Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


vicare documentation
vicare source
(message by IssueLinks)

@NoRi2909
Copy link
Contributor Author

And probably something that can be done alongside the fix above:

The custom attributes of the main climate entity are not available in the strings file for the integration to translate. Thus they show up in English:

Screenshot 2024-10-21 09 06 52

The standard climate attributes higher up in the list (not visible in the screenshot) are all showing up in German here as expected.

FYI: In actions there is a frontend bug that HVAC modes and presets don't show up localized:
home-assistant/frontend#22452
That will have to be addressed by the frontend team, those are standard strings for climate entities.

@NoRi2909
Copy link
Contributor Author

Hi @CFenner , I saw you added 'Cooling electricity' entities today. Do you have time to address the photovoltaic and pump entities in the coming days?

And let me know what you think about the custom climate attributes not showing up on Automations.

"Heating curve shift" and "Heating curve slope" show up translated in the device UI, but those are separate entities, not attributes of the main Heating entity:

Screenshot 2024-10-25 16 50 38

So I assume that the integration also needs to provide a list of keys for these attributes so we can translate them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant