-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis task for Linting times out #10669
Comments
See tox-dev/tox#403 with a new verbose option in tox. Needs tox >= 2.5.0. |
Another solution is to extend the time that travis waits: |
Ok, I've tested running travis with the new tox option, So now the options are, either find a way to get pylint to give output during its run, or extend the |
Oh, we can extend travis_wait. Well, let's do that right away… You're right that verbose tox is not going to help if travis_wait wraps the whole process. Hmm |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 |
Problem
This started happening recently as we've gathered more requirements.
For the linting task, we will install ALL requirements of all platforms. This is currently 375 packages, not counting any of their dependencies. The reason we do this is:
dev
Tox will not show any output of the command while the command is running.
Travis will kill any command that hasn't produced any output for 10 minutes. We bump this to 20 minutes by prefixing command with
travis_wait
Result: tox gets killed by travis and we need to restart the build and hope for a faster machine.
Possible Solutions
pylint
,flake8
andpydocstyle
. We could moveflake8
andpydocstyle
to their own task, as they don't need any requirements installed. This will buy us some extra time.tox
to show the installation progress to prevent Travis from timing outpylint
to not care about 3rd party dependencies. (We still want to install everything, just not lint it)The text was updated successfully, but these errors were encountered: