Reviews

Author: autinerd

homeassistant/components/eheimdigital/coordinator.py

@@ -10,7 +10,7 @@
 from eheimdigital.types import EheimDeviceType
 
 from homeassistant.config_entries import ConfigEntry
-from homeassistant.const import CONF_HOST, Platform
+from homeassistant.const import CONF_HOST
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.aiohttp_client import async_get_clientsession
 from homeassistant.helpers.entity_component import DEFAULT_SCAN_INTERVAL
@@ -26,7 +26,7 @@ class EheimDigitalUpdateCoordinator(
 ):
     """The EHEIM Digital data update coordinator."""
 
-    platform_callbacks: dict[Platform, AsyncSetupDeviceEntitiesCallback]
+    platform_callbacks: set[AsyncSetupDeviceEntitiesCallback]
     config_entry: ConfigEntry
     hub: EheimDigitalHub
     known_devices: set[str]
@@ -44,16 +44,14 @@ def __init__(self, hass: HomeAssistant) -> None:
             device_found_callback=self._async_device_found,
         )
         self.known_devices = set()
-        self.platform_callbacks = {}
+        self.platform_callbacks = set()
 
     def add_platform_callback(
         self,
-        platform: Platform,
         async_setup_device_entities: AsyncSetupDeviceEntitiesCallback,
     ) -> None:
         """Add the setup callbacks from a specific platform."""
-        if platform not in self.platform_callbacks:
-            self.platform_callbacks[platform] = async_setup_device_entities
+        self.platform_callbacks.add(async_setup_device_entities)
 
     async def _async_device_found(
         self, device_address: str, device_type: EheimDeviceType
@@ -64,7 +62,7 @@ async def _async_device_found(
         """
 
         if device_address not in self.known_devices:
-            for platform_callback in self.platform_callbacks.values():
+            for platform_callback in self.platform_callbacks:
                 await platform_callback(device_address)
 
     async def _async_receive_callback(self) -> None:

homeassistant/components/eheimdigital/light.py

@@ -13,7 +13,6 @@
     LightEntity,
     LightEntityFeature,
 )
-from homeassistant.const import Platform
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from homeassistant.util.color import brightness_to_value, value_to_brightness
@@ -48,7 +47,10 @@ async def async_setup_device_entities(device_address: str) -> None:
                     coordinator.known_devices.add(device.mac_address)
         async_add_entities(entities)
 
-    coordinator.add_platform_callback(Platform.LIGHT, async_setup_device_entities)
+    coordinator.add_platform_callback(async_setup_device_entities)
+
+    for device_address in entry.runtime_data.hub.devices:
+        await async_setup_device_entities(device_address)
 
 
 class EheimDigitalClassicLEDControlLight(

tests/components/eheimdigital/test_light.py

@@ -53,7 +53,8 @@ async def test_setup_classic_led_ctrl(
 
     with patch("homeassistant.components.eheimdigital.PLATFORMS", [Platform.LIGHT]):
         await hass.config_entries.async_setup(mock_config_entry.entry_id)
-    await mock_config_entry.runtime_data._async_device_found(
+
+    await eheimdigital_hub_mock.call_args.kwargs["device_found_callback"](
         "00:00:00:00:00:01", EheimDeviceType.VERSION_EHEIM_CLASSIC_LED_CTRL_PLUS_E
     )
     await hass.async_block_till_done()
@@ -143,7 +144,7 @@ async def test_turn_on_brightness(
 
     with patch("homeassistant.components.eheimdigital.PLATFORMS", [Platform.LIGHT]):
         await hass.config_entries.async_setup(mock_config_entry.entry_id)
-    await mock_config_entry.runtime_data._async_device_found(
+    await eheimdigital_hub_mock.call_args.kwargs["device_found_callback"](
         "00:00:00:00:00:01", EheimDeviceType.VERSION_EHEIM_CLASSIC_LED_CTRL_PLUS_E
     )
     await hass.async_block_till_done()
@@ -180,7 +181,7 @@ async def test_turn_on_effect(
 
     with patch("homeassistant.components.eheimdigital.PLATFORMS", [Platform.LIGHT]):
         await hass.config_entries.async_setup(mock_config_entry.entry_id)
-    await mock_config_entry.runtime_data._async_device_found(
+    await eheimdigital_hub_mock.call_args.kwargs["device_found_callback"](
         "00:00:00:00:00:01", EheimDeviceType.VERSION_EHEIM_CLASSIC_LED_CTRL_PLUS_E
     )
     await hass.async_block_till_done()
@@ -216,7 +217,7 @@ async def test_state_update(
 
     with patch("homeassistant.components.eheimdigital.PLATFORMS", [Platform.LIGHT]):
         await hass.config_entries.async_setup(mock_config_entry.entry_id)
-    await mock_config_entry.runtime_data._async_device_found(
+    await eheimdigital_hub_mock.call_args.kwargs["device_found_callback"](
         "00:00:00:00:00:01", EheimDeviceType.VERSION_EHEIM_CLASSIC_LED_CTRL_PLUS_E
     )
     await hass.async_block_till_done()