Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only direct connections #19

Open
nbarrientos opened this issue Mar 23, 2024 · 5 comments
Open

Show only direct connections #19

nbarrientos opened this issue Mar 23, 2024 · 5 comments

Comments

@nbarrientos
Copy link

Hi,

Sorry for posting here stuff about the HA integration but I thought it'd be faster to reach you :)

Would it be feasible to patch the HA integration to configure a given connection to only show direct connections? This lib and the API seem to support it.

It does not seem complicated: maybe an extra user_input in config_flow which would enable the direct parameter in the OpendataTransport object. I don't have much experience touching the HA codebase but I can try.

What do you think?

@nbarrientos
Copy link
Author

Maybe I spoke too fast: OpendataCH/Transport#216

@nbarrientos
Copy link
Author

So yeah, according to the reply in the ticket above the direct parameter (and many more) are not supported anymore.

There's still the chance to keep the parameter in the library and do the filtering at this stage to kind of simulate the missing functionality in the API. Would you be willing to review a patch to do so?

@nbarrientos
Copy link
Author

Ping @miaucl

@miaucl
Copy link
Contributor

miaucl commented Apr 1, 2024

Hey guys, as you might know, it takes some time to integrate into HA and as it was a old integration, the focus lies first on clean up before new features are considered. But yes, this is already on my radar 👍

@nbarrientos
Copy link
Author

Great, if I can help somehow here I am. I'm specially interested in being able to filter out non-direct connections, preferably at HA level. I've seen a patch of yours has been recently merged in HA to have separate entities per departure. If each departure_x had the transfers attribute it'd be easy to filter in templates, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants