Correctly unpack vega datasets #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
reviewed
Jan 7, 2020
| @@ -55,6 +55,12 @@ export class VegaPlotView extends HTMLBoxView { | |||
| this.model.data.data['values'] = datasets['data'] | |||
| delete datasets['data'] | |||
| } | |||
| for (const d of this.model.data.data) { | |||
| if (d.name in datasets) { | |||
There was a problem hiding this comment.
Being pedantic, this should use datasets.hasOwnProperty(d.name). This way, if d.name overlaps with an inherited member, but d.name isn't generated by this._fetch_datasets(), then you won't get a false positive in this clause. Alternatively _fetch_datasets() could return a plain object created with Object.create(null) instead of {}. Then you can use in operator freely.
sthagen
added a commit
to sthagen/holoviz-panel
that referenced
this pull request
Jan 7, 2020
Correctly unpack vega datasets (holoviz#927)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.