Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Markdown handling #881

Merged
merged 11 commits into from
Dec 18, 2019
Merged

Improve Markdown handling #881

merged 11 commits into from
Dec 18, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 18, 2019

Implements #828
Implements #391

pn.pane.Markdown("""
    # Markdown syntax

    # Title h1

    ## Title h2

    ### Title h3

    #### Title h4

    ## Paragraphs

    Lorem ipsum dolor sit amet, vis suscipit expetendis ut, laoreet instructior at vel, nullam efficiantur sit ex. Ei graeco quaeque omittam vis, qui no bonorum gloriatur. Ut sed aliquam convenire, enim nihil efficiendi eu sea. Ne affert eripuit minimum vis, te vel docendi interesset, vix ea quot albucius gloriatur.

    Lorem ipsum dolor sit amet, vis suscipit expetendis ut, laoreet instructior at vel, nullam efficiantur sit ex. Ei graeco quaeque omittam vis, qui no bonorum gloriatur. Ut sed aliquam convenire, enim nihil efficiendi eu sea. Ne affert eripuit minimum vis, te vel docendi interesset, vix ea quot albucius gloriatur.

    ## Quoted text

    In the words of Abraham Lincoln:

    > Pardon my French

    ## Syntax highlighting

    Some basic Git commands are:

    ```text
    git status
    git add
    git commit
    ```

    ```python
    def some_function():
        return 1
    ```

    ```javascript
    function some_function () {
        return 1
    }
    ```

    ## Bullet Points

    - George Washington
    - John Adams
    - Thomas Jefferson

    ## Ordered List

    1. James Madison
    2. James Monroe
    3. John Quincy Adams

    ## Nested list

    1. First list item
        - First nested list item
            - Second nested list item
""", sizing_mode='stretch_width').show()

Screen Shot 2019-12-18 at 2 15 04 PM

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Dec 18, 2019
@philippjfr philippjfr merged commit 7a9ed61 into master Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #881 into master will decrease coverage by <.01%.
The diff coverage is 74.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
- Coverage   69.71%   69.71%   -0.01%     
==========================================
  Files         104      104              
  Lines       10554    10587      +33     
==========================================
+ Hits         7358     7381      +23     
- Misses       3196     3206      +10
Impacted Files Coverage Δ
panel/tests/pane/test_markup.py 100% <100%> (ø) ⬆️
panel/tests/pane/test_base.py 84% <50%> (-16%) ⬇️
panel/pane/markup.py 51% <55.55%> (-0.75%) ⬇️
panel/util.py 66.39% <75%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14728a...e45cb28. Read the comment docs.

sthagen added a commit to sthagen/holoviz-panel that referenced this pull request Dec 18, 2019
@philippjfr philippjfr added this to the v0.8.0 milestone Jan 16, 2020
@philippjfr philippjfr deleted the markdown_enhancements branch January 23, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant