Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Markdown example #670

Merged
merged 7 commits into from
Oct 4, 2019
Merged

Updated Markdown example #670

merged 7 commits into from
Oct 4, 2019

Conversation

Jacob-Barhak
Copy link
Contributor

The new example shows a markdown hyper link and how to style table borders using various methods and discusses their advantages and disadvantages

The new example shows a markdown hyper link and how to style table borders using various methods and discusses their advantages and disadvantages
@philippjfr
Copy link
Member

Thanks @Jacob-Barhak. Would you mind clearing the notebook before committing it. Storing the output would bloat the repository and makes it impossible to review.

@Jacob-Barhak
Copy link
Contributor Author

Jacob-Barhak commented Oct 1, 2019 via email

cleaned notebook is now compact
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run the notebook, but it looks useful to me from the source code after these changes.

examples/reference/panes/Markdown.ipynb Outdated Show resolved Hide resolved
examples/reference/panes/Markdown.ipynb Outdated Show resolved Hide resolved
examples/reference/panes/Markdown.ipynb Outdated Show resolved Hide resolved
examples/reference/panes/Markdown.ipynb Outdated Show resolved Hide resolved
examples/reference/panes/Markdown.ipynb Outdated Show resolved Hide resolved
@Jacob-Barhak
Copy link
Contributor Author

Thanks James,

The text in the suggested changes are much better.

@philippjfr
Copy link
Member

@Jacob-Barhak Could you apply @jbednar's suggestions?

@jbednar
Copy link
Member

jbednar commented Oct 3, 2019

Looks good to me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants