Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic vscode detection is not always working #5200

Closed
hoxbro opened this issue Jul 3, 2023 · 5 comments · Fixed by #5201
Closed

Automatic vscode detection is not always working #5200

hoxbro opened this issue Jul 3, 2023 · 5 comments · Fixed by #5201
Labels
type: enhancement Minor feature or improvement to an existing feature

Comments

@hoxbro
Copy link
Member

hoxbro commented Jul 3, 2023

Continuation of #5007.

When running VSCode inside a virtualization/containerized environment, for example, WSL on Windows, the system environment variable we use VSCODE_PID to detect if we are running inside a vs code notebook is not set. Below is an example of the VSCODE_ environment variables set in a notebook environment on WSL.

import os
sorted(k for k in os.environ if "VSCODE" in k)

image

image

@hoxbro hoxbro added the TRIAGE Default label for untriaged issues label Jul 3, 2023
@hoxbro
Copy link
Member Author

hoxbro commented Jul 3, 2023

@giladpn, Is it possible for you to run the above code in a notebook running in a docker container?

@giladpn
Copy link

giladpn commented Jul 3, 2023

@hoxbro Done. I ran this on a docker RHEL9 container:
image

@philippjfr
Copy link
Member

Would propose we check for VSCODE_CWD in addition to VSCODE_PID

@MarcSkovMadsen
Copy link
Collaborator

What about warning if jupyter_bokeh not installed?

@hoxbro
Copy link
Member Author

hoxbro commented Jul 3, 2023

Unrelated to this issue.

See your own issue here #5190

@hoxbro hoxbro added type: enhancement Minor feature or improvement to an existing feature and removed TRIAGE Default label for untriaged issues labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants