Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integer volume and non-null default value #4970

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 30, 2023

I can see the video pane model uses an integer for volumen and have a default value of 100 when null is used.

import panel as pn
pn.extension()

video = pn.pane.Video('/home/shh/Downloads/sample-mp4-file-small.mp4', width=640, loop=True)
#pn.Row(video.controls(jslink=True), video)

video
sample-mp4-file-small.mp4

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #4970 (e2ae8a0) into main (2ab34b3) will decrease coverage by 2.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4970      +/-   ##
==========================================
- Coverage   83.49%   80.83%   -2.66%     
==========================================
  Files         270      271       +1     
  Lines       38239    38253      +14     
==========================================
- Hits        31926    30923    -1003     
- Misses       6313     7330    +1017     
Flag Coverage Δ
ui-tests 40.87% <100.00%> (-0.01%) ⬇️
unitexamples-tests 70.79% <100.00%> (-2.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/media.py 92.23% <100.00%> (+0.07%) ⬆️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@philippjfr philippjfr merged commit 0536c89 into main May 30, 2023
10 of 14 checks passed
@philippjfr philippjfr deleted the video_volume branch May 30, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants