Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactTemplate and used external resources #3565

Closed
keul opened this issue May 27, 2022 · 1 comment · Fixed by #4461
Closed

ReactTemplate and used external resources #3565

keul opened this issue May 27, 2022 · 1 comment · Fixed by #4461
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@keul
Copy link
Contributor

keul commented May 27, 2022

ALL software version info

  • panel 0.12.7

Description of expected behavior and the observed behavior

Testing a panel application using ReactTemplate on both embedded mode inside JupyterLab and using the panel serve --show.

Looking at

'react': "https://unpkg.com/react@16/umd/react.development.js",
I see

  1. while React is fixed to most updated 16 version (OK), poiting to https://unpkg.com/babel-standalone@latest/babel.min.js seems not a good idea
  2. react-grid-layout use a different CDN (but using the same of react is possible: https://unpkg.com/[email protected])
  3. react is loaded using development bundle

The last one is the bigger issue in my opinion. Having the development version of React is useful for local development and testing purpose, but it's not something to be distributed to users.

Please note: I'm pretty new with Jupyter+panel, I don't know if there is a "debug mode" that can be activated or not.
If so: probably the best would be to load the .dev version only in this case. But an applications served using panel serve --show xxxx should use the production bundle.

Screenshots or screencasts of the bug in action

Schermata 2022-05-27 alle 12 31 18

@maximlt maximlt added the type: bug Something isn't correct or isn't working label Jun 2, 2022
@maximlt
Copy link
Member

maximlt commented Jun 2, 2022

I guess I would agree with your suggestions, thoughts on this one @philippjfr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants