Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logic to avoid events boomeranging #288

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Conversation

philippjfr
Copy link
Member

The _expecting flag which was an attempt to ensure that events don't bounce around was not actually doing anything. Additionally the bi-directional link between a Parameterized and a widget was also not handled correctly and is now replaced by a _updating flag on the Param pane.

@codecov-io
Copy link

Codecov Report

Merging #288 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   88.67%   88.63%   -0.04%     
==========================================
  Files          60       60              
  Lines        6002     6000       -2     
==========================================
- Hits         5322     5318       -4     
- Misses        680      682       +2
Impacted Files Coverage Δ
panel/param.py 90.39% <100%> (+0.74%) ⬆️
panel/viewable.py 72.75% <100%> (-0.06%) ⬇️
panel/util.py 66.12% <0%> (-1.21%) ⬇️
panel/pane/image.py 81.11% <0%> (-1.12%) ⬇️
panel/interact.py 73.03% <0%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2a597...5482b9e. Read the comment docs.

@philippjfr philippjfr merged commit c9c779f into master Mar 8, 2019
@philippjfr philippjfr deleted the boomerang_fix branch September 9, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants