Implement hierarchical aggregation for Tabulator #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Aug 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #2624 +/- ##
=======================================
Coverage 83.09% 83.09%
=======================================
Files 184 184
Lines 23295 23309 +14
=======================================
+ Hits 19356 19369 +13
- Misses 3939 3940 +1
Continue to review full report at Codecov.
|
mathrick
reviewed
Sep 9, 2021
panel/models/tabulator.ts
Outdated
| const formatted = column.formatter.doFormat(cell.getRow(), cell, cell.getValue(), null, null) | ||
| const node = div() | ||
| node.innerHTML = formatted | ||
| return node.children[0].innerHTML |
There was a problem hiding this comment.
This completely breaks HTMLTemplateFormatter:
pn.widgets.Tabulator(pd.DataFrame({'link': ['foo']}),
formatters={'link': HTMLTemplateFormatter(
template='<a href="<%= value %>">Link</a>'
)})There was a problem hiding this comment.
Thanks, can you open an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2619