Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved behavior for fixed widths and heights #258

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 1, 2019

This PR forces a fixed height to be respected if specified either by setting sizing_mode='fixed' or by setting the corresponding min_width or min_height property at the same time.

Fixes #23

@jsignell
Copy link
Member

jsignell commented Mar 1, 2019

Fixes the issue I was seeing locally thanks!

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #258 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +0.01%     
==========================================
  Files          44       44              
  Lines        5437     5445       +8     
==========================================
+ Hits         4856     4864       +8     
  Misses        581      581
Impacted Files Coverage Δ
panel/layout.py 95.63% <100%> (-0.13%) ⬇️
panel/tests/test_reactive.py 100% <100%> (ø) ⬆️
panel/tests/test_widgets.py 100% <100%> (ø) ⬆️
panel/viewable.py 72.52% <100%> (+1.59%) ⬆️
panel/widgets.py 94.42% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aedd25...9a3b0e3. Read the comment docs.

@philippjfr philippjfr merged commit 9791933 into master Mar 1, 2019
@philippjfr philippjfr deleted the fixed_width_height_fixes branch March 6, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Row and Column have width and height parameters?
3 participants