Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested parameterized objects on ReactiveHTML #2533

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Conversation

philippjfr
Copy link
Member

This means that ReactiveHTML objects can now declare parameters of type ClassSelector(class_=Parameterized) which are automatically reflected as DataModels on the JS side and automatically synced.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #2533 (e32933c) into master (d27ffec) will increase coverage by 0.23%.
The diff coverage is 63.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2533      +/-   ##
==========================================
+ Coverage   83.00%   83.23%   +0.23%     
==========================================
  Files         184      184              
  Lines       22721    23226     +505     
==========================================
+ Hits        18859    19332     +473     
- Misses       3862     3894      +32     
Impacted Files Coverage Δ
panel/models/reactive_html.py 79.20% <0.00%> (ø)
panel/links.py 78.48% <25.00%> (-1.42%) ⬇️
panel/reactive.py 74.56% <66.66%> (-0.81%) ⬇️
panel/layout/tabs.py 86.45% <100.00%> (+0.14%) ⬆️
panel/tests/layout/test_tabs.py 100.00% <100.00%> (ø)
panel/tests/test_reactive.py 99.06% <100.00%> (ø)
panel/tests/test_server.py 100.00% <100.00%> (ø)
panel/tests/pane/test_echart.py 37.93% <0.00%> (-1.36%) ⬇️
panel/pane/alert.py 100.00% <0.00%> (ø)
panel/tests/test_docs.py 100.00% <0.00%> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27ffec...e32933c. Read the comment docs.

@philippjfr philippjfr merged commit 423c991 into master Jul 14, 2021
@philippjfr philippjfr deleted the reactive_nested branch July 14, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant