Fix broken serialisation in panel.io.location #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serialised value was never actually captured, which would invariably lead to JSON serialisation errors for any value other than a simple string
Codecov Report
@@ Coverage Diff @@
## master #2520 +/- ##
=======================================
Coverage 83.30% 83.30%
=======================================
Files 184 184
Lines 23186 23186
=======================================
+ Hits 19314 19315 +1
+ Misses 3872 3871 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialised value was never actually captured, which would invariably lead to JSON serialisation errors for any value other than a simple string