Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure config per session state works for resources #2455

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

philippjfr
Copy link
Member

While I recently added support for per-session state on pn.config this didn't fully work for the resource related parameters such as css_files, js_files etc. because a) they are mutable so they need to create entries on access and b) while the session handler is running state.curdoc was not set to the correct value.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #2455 (a741748) into master (fbdd1fa) will increase coverage by 0.00%.
The diff coverage is 86.48%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2455   +/-   ##
=======================================
  Coverage   83.41%   83.42%           
=======================================
  Files         183      183           
  Lines       22773    22804   +31     
=======================================
+ Hits        18997    19025   +28     
- Misses       3776     3779    +3     
Impacted Files Coverage Δ
panel/io/server.py 61.63% <50.00%> (+0.07%) ⬆️
panel/config.py 60.21% <100.00%> (+0.49%) ⬆️
panel/tests/test_server.py 100.00% <100.00%> (ø)
panel/tests/pane/test_plotly.py 98.10% <0.00%> (-0.64%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdd1fa...a741748. Read the comment docs.

@philippjfr philippjfr merged commit 1a43a41 into master Jun 29, 2021
@philippjfr philippjfr deleted the config_per_session branch June 29, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant