Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Plotly interactivity works when Plotly panes are displayed in tabs #2418

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

philippjfr
Copy link
Member

Uses JS callbacks to ensure that Plotly panes displayed inside Tabs are hidden when the tab they are in is not active. This ensures that interactivity on the plots still works even when they are overlapping.

Fixes #804

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #2418 (c791316) into master (040b887) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
+ Coverage   83.45%   83.49%   +0.03%     
==========================================
  Files         185      185              
  Lines       22680    22734      +54     
==========================================
+ Hits        18928    18982      +54     
  Misses       3752     3752              
Impacted Files Coverage Δ
panel/pane/plotly.py 92.75% <100.00%> (+1.32%) ⬆️
panel/tests/pane/test_plotly.py 98.73% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040b887...c791316. Read the comment docs.

@philippjfr philippjfr merged commit b626216 into master Jun 23, 2021
@philippjfr philippjfr deleted the 804_plotly_tabs_interactivity branch June 23, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected Interactivity of "layered" plotly objects in Tabs
1 participant