Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for Template modals #2269

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Enhancements for Template modals #2269

merged 5 commits into from
Apr 30, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 30, 2021

Replaces custom modal implementations with the native implementations for Fast, Bootstrap and Material and ensures they are sized correctly.

@MarcSkovMadsen I've also removed the footer that says "Made with". It's nice to attribute Panel/Fast etc. but in many cases not appropriate. I'd be open to adding a footer area and perhaps even adding that by default but having no way to disable it just won't work.

Lastly this PR replaces the "hacky" HTML pane which is used to send executable scripts with a TemplateActions ReactiveHTML component which can trigger specific (pre-defined) actions simply by updating a single variable.

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #2269 (8a1f2a7) into master (7d42a99) will decrease coverage by 0.01%.
The diff coverage is 27.27%.

❗ Current head 8a1f2a7 differs from pull request most recent head 4135a0b. Consider uploading reports for the commit 4135a0b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2269      +/-   ##
==========================================
- Coverage   83.61%   83.60%   -0.02%     
==========================================
  Files         183      183              
  Lines       21928    21935       +7     
==========================================
+ Hits        18336    18339       +3     
- Misses       3592     3596       +4     
Impacted Files Coverage Δ
panel/template/base.py 78.14% <0.00%> (ø)
panel/template/fast/base.py 93.18% <ø> (ø)
panel/template/material/__init__.py 88.23% <42.85%> (-11.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d42a99...4135a0b. Read the comment docs.

@philippjfr philippjfr merged commit c36e80b into master Apr 30, 2021
@philippjfr philippjfr deleted the modal_enhancements branch April 30, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant