Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theming on HoloViews plot updates #2209

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Fix theming on HoloViews plot updates #2209

merged 1 commit into from
Apr 18, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 18, 2021

Fixes #1816
Fixes #2207

@hoxbro
Copy link
Member

hoxbro commented Apr 18, 2021

I just tested, and this does also fix #1816.

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@c84ee56). Click here to learn what that means.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2209   +/-   ##
=========================================
  Coverage          ?   83.81%           
=========================================
  Files             ?      182           
  Lines             ?    21789           
  Branches          ?        0           
=========================================
  Hits              ?    18263           
  Misses            ?     3526           
  Partials          ?        0           
Impacted Files Coverage Δ
panel/template/base.py 78.14% <66.66%> (ø)
panel/pane/holoviews.py 79.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84ee56...86e7ae4. Read the comment docs.

@philippjfr
Copy link
Member Author

It does indeed.

@philippjfr philippjfr merged commit de05bff into master Apr 18, 2021
@philippjfr philippjfr deleted the bokeh_hv_theme branch April 18, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bokeh Theme is lost on update Bokeh dark theme lost when removing and adding HoloViews pane
2 participants