Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Card.collapsed and Accordion.active parameters are synced #2009

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2005
Fixes #2006

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #2009 (c1cfe35) into master (521cd34) will increase coverage by 0.01%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
+ Coverage   84.81%   84.83%   +0.01%     
==========================================
  Files         166      166              
  Lines       19996    20031      +35     
==========================================
+ Hits        16960    16993      +33     
- Misses       3036     3038       +2     
Impacted Files Coverage Δ
panel/layout/accordion.py 88.04% <95.83%> (+3.32%) ⬆️
panel/layout/card.py 95.83% <100.00%> (+0.08%) ⬆️
panel/tests/layout/test_accordion.py 96.93% <100.00%> (+0.34%) ⬆️
panel/io/reload.py 65.88% <0.00%> (-2.36%) ⬇️
panel/widgets/input.py 95.83% <0.00%> (-0.04%) ⬇️
panel/widgets/select.py 93.51% <0.00%> (+0.02%) ⬆️
panel/tests/test_reactive.py 98.88% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521cd34...c1cfe35. Read the comment docs.

@philippjfr philippjfr merged commit 7547caf into master Feb 25, 2021
@philippjfr philippjfr deleted the card_collapsed branch February 25, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion's active does not work correctly Card's collapsed returns False for collapsed card
1 participant