Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --warm option to panel serve #1971

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Add --warm option to panel serve #1971

merged 2 commits into from
Feb 12, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 10, 2021

Allows executing scripts on startup to ensure the caches are warmed up

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1971 (9d37f4c) into master (2cb9d02) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1971      +/-   ##
==========================================
- Coverage   84.87%   84.85%   -0.03%     
==========================================
  Files         154      154              
  Lines       19122    19128       +6     
==========================================
+ Hits        16230    16231       +1     
- Misses       2892     2897       +5     
Impacted Files Coverage Δ
panel/command/serve.py 17.59% <16.66%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb9d02...9d37f4c. Read the comment docs.

@philippjfr philippjfr added this to the v0.11.0 milestone Feb 11, 2021
@philippjfr philippjfr changed the title Add --warm-cache option to panel serve Add --warm option to panel serve Feb 11, 2021
@MarcSkovMadsen
Copy link
Collaborator

Remember to include a warm option to panel.serve @philippjfr :-)

@philippjfr
Copy link
Member Author

I guess I could but if you're already using panel.serve then you are already running a script which can much more effectively "warm up" the session by populating the pn.state.cache and running the desired imports. Do you still think it's useful?

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Feb 12, 2021

In my experience having the same options from panel serve and panel.serve is what is by some users (me) expected. It’s confusing when there is a discrepancy.

but i can see here that it might not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants