Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates get stuck on DarkTheme in notebooks after they're set once. #1417

Closed
kebowen730 opened this issue Jun 16, 2020 · 1 comment
Closed
Labels
type: enhancement Minor feature or improvement to an existing feature

Comments

@kebowen730
Copy link
Contributor

kebowen730 commented Jun 16, 2020

On Panel 0.9.5 while testing a new Template I ran into a bug related to DarkTheme.

Ive been using the Template.ipynb notebook in the user_guide directiory to test my new template, and for some reason once I set a template with theme=DarkTheme , it always renders with DarkTheme even if I set it back to DefaultTheme, unless I restart the Kernel. This occurs with the new GoldenTemplate that I'm testing, as well as MaterialTemplate and BootstrapTemplate. This only occurs with DarkTheme, DefaultTheme is overridden when it's changed. It seems like an issue with the css sticking around, but I'm not sure what causes it or why it's only with DarkTheme.

To reproduce, in a notebook run:

import panel as pn

bootstrap = pn.template.BootstrapTemplate(title='Bootstrap Template', theme=pn.template.DefaultTheme)

bootstrap.show

change it to this and run:

import panel as pn

bootstrap = pn.template.BootstrapTemplate(title='Bootstrap Template', theme=pn.template.DarkTheme)

bootstrap.show

and then run again after reverting to the original codeblock, this can also be done using the second python cell in the Panel User Guide notebook I referenced above.

@kebowen730 kebowen730 added the TRIAGE Default label for untriaged issues label Jun 16, 2020
@philippjfr philippjfr added type: enhancement Minor feature or improvement to an existing feature and removed TRIAGE Default label for untriaged issues labels Jun 20, 2020
@philippjfr
Copy link
Member

Fixed in #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants