-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compositional reprs #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
+ Coverage 89.63% 89.94% +0.3%
=========================================
Files 27 27
Lines 4034 4196 +162
=========================================
+ Hits 3616 3774 +158
- Misses 418 422 +4
Continue to review full report at Codecov.
|
That's a good start, thanks! I'd rather avoid the parentheses after Column and Row; this is not an eval-able expression, and I think it's better to make that clear (and avoid the extra whitespace). The representation also doesn't yet achieve indicating how to index into this object, which is a feature of HoloViews reprs that I really find helpful. For that it would need to have numbers on the Row and Column entries to indicate which how to index the whole structure to reach that part. But of course implementing that can be postponed... |
How's this:
|
Looks fabulous to me! I can super easily now pull out [0][5] and work with it! |
I can't wait to update my |
I think we need to limit the reprs:
|
Yes, I'll add a function to generate shortened reprs for parameter values. |
@jbednar Mind playing around a bit? |
Looks great to me:
|
An initial implementation of compositional reprs, which can be improved later.
Some sample outputs for moderately complex dashboards include: