Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example markup for Secondary buttons shouldn't include the button class #908

Closed
gordonmcmullan opened this issue Jan 30, 2018 · 0 comments
Closed

Comments

@gordonmcmullan
Copy link
Contributor

govuk-elements doesn't use .buton--secondary as a mixin but as a replacement for .button

Problem/Feature

Developers following our markup examples for v3.x markup are getting Green buttons instead of the expected grey buttons with the .button--secondary class. This is a change from v2.x when `class=button button--secondary' would have rendered the button as grey.

Expected behaviour

Secondary buttons should be Grey

Proposed solution

Change the markup examples and the example button to use only the button--secondary class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant