AutoComplete has English language hard-coded

[adamliptrot-oc]

Problem/Feature

AutoComplete has a message in English hard-coded:
https://github.com/hmrc/assets-frontend/blob/master/assets/javascripts/modules/autoComplete.js#L98
This means that in the event of an alternate language being used for the main content (e.g. Welsh), the accessibility help will still be read in English.

Expected behaviour

The help message should be in the same language as the main body of the page

Proposed solution

This could possibly be done by detecting the language being used on the page (though this does not to be always set correctly), or via a parameter set via a data-attribute.

Explain the steps to reproduce the bug

Using VoiceOver, interact with the autoComplete component. When suggestion matches are found, the following is announced: " suggestions available, please navigate by using up and down"

[feedmypixel]

I'd vote for a data-attribute sending in an alternative to a hard coded default.

[rpowis]

@feedmypixel I'm not sold on that idea. I think it depends on how the language changing is handled.

[rpowis]

In any case we should wait for the pattern to come up for review before worrying about a solution to it. There's been a lot of discussion about autocomplete in cross-gov slack and there are generally more accessible versions than this one that we might want to use instead.